Use pathlib where possible

app/models/job.py

@@ -4,7 +4,7 @@ from flask import current_app, url_for
 from flask_hashids import HashidMixin
 from time import sleep
 from typing import Union
-import os
+from pathlib import Path
 import shutil
 from app import db
 from app.ext.flask_sqlalchemy import ContainerColumn, IntEnumColumn
@@ -79,8 +79,8 @@ class Job(HashidMixin, db.Model):
         return f'{self.user.jsonpatch_path}/jobs/{self.hashid}'
 
     @property
-    def path(self):
-        return os.path.join(self.user.path, 'jobs', str(self.id))
+    def path(self) -> Path:
+        return self.user.path / 'jobs' / f'{self.id}'
 
     @property
     def url(self):
@@ -96,15 +96,19 @@ class Job(HashidMixin, db.Model):
         db.session.add(job)
         db.session.flush(objects=[job])
         db.session.refresh(job)
+        job_inputs_dir = job.path / 'inputs'
+        job_pipeline_data_dir = job.path / 'pipeline_data'
+        job_results_dir = job.path / 'results'
         try:
-            os.mkdir(job.path)
-            os.mkdir(os.path.join(job.path, 'inputs'))
-            os.mkdir(os.path.join(job.path, 'pipeline_data'))
-            os.mkdir(os.path.join(job.path, 'results'))
+            job.path.mkdir()
+            job_inputs_dir.mkdir()
+            job_pipeline_data_dir.mkdir()
+            job_results_dir.mkdir()
         except OSError as e:
+            # TODO: Potential leftover cleanup
             current_app.logger.error(e)
             db.session.rollback()
-            raise e
+            raise
         return job
 
     def delete(self):
@@ -131,8 +135,8 @@ class Job(HashidMixin, db.Model):
         ''' Restart a job - only if the status is failed '''
         if self.status != JobStatus.FAILED:
             raise Exception('Job status is not "failed"')
-        shutil.rmtree(os.path.join(self.path, 'results'), ignore_errors=True)
-        shutil.rmtree(os.path.join(self.path, 'pyflow.data'), ignore_errors=True)
+        shutil.rmtree(self.path / 'results', ignore_errors=True)
+        shutil.rmtree(self.path / 'pyflow.data', ignore_errors=True)
         for result in self.results:
             db.session.delete(result)
         self.end_date = None