sporada/nopaque
1
0
Fork 0
mirror of https://gitlab.ub.uni-bielefeld.de/sfb1288inf/nopaque.git synced 2024-12-25 02:44:18 +00:00
Code Issues Projects Releases Wiki Activity

Remove TODOs that are done

Browse Source
This commit is contained in:
Patrick Jentsch 2023-06-30 14:18:07 +02:00
parent e21ef2422d
commit 912bd7da07
3 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/static/js/CorpusAnalysis/CorpusAnalysisApp.js
View File

@ -55,7 +55,6 @@ class CorpusAnalysisApp {
this.elements.m.initModal.close(); this.elements.m.initModal.close();
}, },
(cqiError) => { (cqiError) => {
// TODO: CHECK THIS!
let errorsElement = this.elements.initModal.querySelector('.errors'); let errorsElement = this.elements.initModal.querySelector('.errors');
let progressElement = this.elements.initModal.querySelector('.progress'); let progressElement = this.elements.initModal.querySelector('.progress');
errorsElement.innerText = JSON.stringify(cqiError); errorsElement.innerText = JSON.stringify(cqiError);

4
app/static/js/CorpusAnalysis/CorpusAnalysisConcordance.js
View File

@ -292,7 +292,7 @@ class CorpusAnalysisConcordance {
event.preventDefault(); event.preventDefault();
let subcorpus = this.data.subcorpora[this.settings.selectedSubcorpus]; let subcorpus = this.data.subcorpora[this.settings.selectedSubcorpus];
subcorpus.o.drop().then( subcorpus.o.drop().then(
cQiStatus => { (cQiStatus) => {
app.flash(`${subcorpus.o.name} deleted`, 'corpus'); app.flash(`${subcorpus.o.name} deleted`, 'corpus');
delete this.data.subcorpora[subcorpus.o.name]; delete this.data.subcorpora[subcorpus.o.name];
this.settings.selectedSubcorpus = undefined; this.settings.selectedSubcorpus = undefined;
@ -313,7 +313,7 @@ class CorpusAnalysisConcordance {
this.clearSubcorpusPagination(); this.clearSubcorpusPagination();
} }
}, },
cQiError => { (cQiError) => {
app.flash(`${cQiError.payload.code}: ${cQiError.payload.msg}`, 'error'); app.flash(`${cQiError.payload.code}: ${cQiError.payload.msg}`, 'error');
} }
); );

2
app/static/js/CorpusAnalysis/CorpusAnalysisReader.js
View File

@ -28,7 +28,6 @@ class CorpusAnalysisReader {
init() { init() {
// Init data // Init data
this.data.corpus = this.app.data.corpus; this.data.corpus = this.app.data.corpus;
this.data.subcorpora = {}; // TODO: DO WE NEED THIS HERE?
// Add event listeners // Add event listeners
this.elements.form.addEventListener('submit', (event) => { this.elements.form.addEventListener('submit', (event) => {
event.preventDefault(); event.preventDefault();
@ -46,7 +45,6 @@ class CorpusAnalysisReader {
this.app.enableActionElements(); this.app.enableActionElements();
}, },
(cqiError) => { (cqiError) => {
// TODO: CHECK THIS!
this.elements.error.innerText = JSON.stringify(error); this.elements.error.innerText = JSON.stringify(error);
this.elements.error.classList.remove('hide'); this.elements.error.classList.remove('hide');
if ('payload' in error && 'code' in error.payload && 'msg' in error.payload) { if ('payload' in error && 'code' in error.payload && 'msg' in error.payload) {